Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unvisited member warning format #36509

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Dec 28, 2019

Summary

SUMMARY: Build "Improve unvisited member warning format"

Purpose of change

Currently the unvisited member warning prints the whole JSON object, leading to over-long warning message if the JSON object is large. This PR makes it print only the nearby lines, by calling throw_error and catch the exception and print the message, like what is done in translations.cpp.

Testing

Ran the unit test and observed the imporved format of unvisited member warning messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants